Skip to content

fix(cooling): show per-group pressures in miners C1 supply/return tables#119

Merged
eskawl merged 2 commits into
tetherto:developfrom
paragmore:feat/cooling-c1-group-pressure-sensors
Jul 2, 2026
Merged

fix(cooling): show per-group pressures in miners C1 supply/return tables#119
eskawl merged 2 commits into
tetherto:developfrom
paragmore:feat/cooling-c1-group-pressure-sensors

Conversation

@paragmore

@paragmore paragmore commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The Cooling → Miners Circuit 1 page (moria-app-ui CircuitMiner) builds three tables per line:

  • SUPPLYline.supply.sensors[]
  • RETURNline.return.sensors[]
  • ΔPline.differential_pressure[]

buildMinersCircuit1View only put [temp, flow] in supply.sensors and [return temp] in return.sensors, so the per-group PT-… · Pressure · Group N rows never appeared in the SUPPLY/RETURN tables — the PTs existed only under differential_pressure, which the FE uses solely for the ΔP table.

This:

  • appends each group's supply/return PT to supply.sensors / return.sensors (type: "Pressure · Group N", reading = supply/return pressure), after the temp/flow rows.
  • numbers groups absolutely (line 1 → Groups 1-8, line 2 → Groups 9-16), since the FE prints entry.group directly on the ΔP rows.
  • keeps the unit on per-group readings even when a PT is unreadable ({ value: null, unit }), consistent with the units-everywhere contract.

paragmore added 2 commits July 2, 2026 19:39
The FE builds the SUPPLY/RETURN tables from line.supply.sensors /
line.return.sensors and the delta-P table from differential_pressure.
Append each group's supply/return PT (type 'Pressure - Group N') to the
sensor lists so the per-group pressures render, and number groups
absolutely (line1 1-8, line2 9-16) since the FE prints entry.group.
@eskawl eskawl merged commit 086e230 into tetherto:develop Jul 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants