fix(cooling): show per-group pressures in miners C1 supply/return tables#119
Merged
eskawl merged 2 commits intoJul 2, 2026
Merged
Conversation
The FE builds the SUPPLY/RETURN tables from line.supply.sensors / line.return.sensors and the delta-P table from differential_pressure. Append each group's supply/return PT (type 'Pressure - Group N') to the sensor lists so the per-group pressures render, and number groups absolutely (line1 1-8, line2 9-16) since the FE prints entry.group.
…feat/cooling-c1-group-pressure-sensors
boris91
approved these changes
Jul 2, 2026
tekwani
approved these changes
Jul 2, 2026
eskawl
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Cooling → Miners Circuit 1 page (
moria-app-uiCircuitMiner) builds three tables per line:line.supply.sensors[]line.return.sensors[]line.differential_pressure[]buildMinersCircuit1Viewonly put[temp, flow]insupply.sensorsand[return temp]inreturn.sensors, so the per-groupPT-… · Pressure · Group Nrows never appeared in the SUPPLY/RETURN tables — the PTs existed only underdifferential_pressure, which the FE uses solely for the ΔP table.This:
supply.sensors/return.sensors(type: "Pressure · Group N", reading = supply/return pressure), after the temp/flow rows.entry.groupdirectly on the ΔP rows.{ value: null, unit }), consistent with the units-everywhere contract.