fix(cooling): keep sensor id on readings even when the tag is unreadable#117
Merged
tekwani merged 1 commit intoJul 2, 2026
Merged
Conversation
Single-sensor summary fields collapsed to null when the tag was not
readable, dropping the sensor label. Add a sensorReading helper that
returns { value, unit, sensor } whenever a sensor is configured (value
null when unreadable), and null only when no sensor is set. Applied to
miners C2 pre/post-HX and tower level, HVAC C2 tower level, and HVAC C1
system pressure.
eskawl
approved these changes
Jul 2, 2026
boris91
approved these changes
Jul 2, 2026
tekwani
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Cooling → Miners → Circuit 2 (and the analogous cards), summary fields that map to a single sensor collapsed to
nullwhen the tag wasn't readable, so the UI lost the sensor label.Adds a
sensorReadinghelper that returns{ value, unit, sensor }whenever a sensor is configured —value: nullwhen the tag isn't readable — andnullonly when no sensor is configured. Applied to:pre_hx_temp,post_hx_temp,tower_leveltower_levelsystem_pressureThe
sensorvalue is the configured device id, consistent with the existing sensortagform elsewhere in the response (e.g. supply/return sensors).