fix(cooling): surface C2 towers, C2 pre/post-HX and C1 pressure averages#116
Merged
eskawl merged 2 commits intoJul 2, 2026
Merged
Conversation
Group differential pressure now reads supply/return/differential from a single transmitter per group (group_pressure_sensors as an ordered list), preferring the DCS-provided differential. Falls back to the legacy supply/return id-pair model. Response shape is unchanged.
- Filter cooling_towers by circuit so each Circuit 2 view shows only its own tower (COOLING_TOWER vs HVAC_CONDENSER). - Read Miners C2 pre/post-HX temps from the loop's configured sensors, falling back to the heat-exchanger-derived values. - Average the Miners C1 header pressures over the 16 per-group PTs, with a line-level fallback, instead of the unset per-line pressure sensors.
boris91
approved these changes
Jul 1, 2026
tekwani
approved these changes
Jul 1, 2026
eskawl
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes so the redesigned Circuit 2 / Circuit 1 cooling views populate correctly from the DCS snap:
equipment.cooling_towersarray, so each rendered the other's tower. Now filtered bycircuit(COOLING_TOWER vs HVAC_CONDENSER), matching the existingfilterPumpsByCircuitpattern.pre_hx_temp_sensor/post_hx_temp_sensor(TT-7581-B / TT-7581-A) instead of the empty heat-exchanger array; HX-derived values kept as a fallback.