Merge worker-level alerts into alerts and history endpoints#115
Merged
tekwani merged 1 commit intoJun 30, 2026
Merged
Conversation
Read worker-level alerts from pool-worker ext data (getWrkExtData 'alerts' / 'alerts-history') and merge them into the site alerts and history-alerts responses. Worker alerts use the same flat shape as thing alerts, so they need no special-casing. Workers opt in via ALERT_EXT_DATA_WORKER_TYPES.
e785bb5 to
37351fa
Compare
boris91
approved these changes
Jun 30, 2026
mukama
approved these changes
Jun 30, 2026
tekwani
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool workers (Ocean, F2Pool) build their own alerts and ship them in ext data instead of going through the thing-scoped alert pipeline. This makes the alerts endpoints surface them.
getSiteAlertsandgetAlertsHistorynow also read worker alerts viagetWrkExtDataand merge them in before summary/dedup/sortALERT_EXT_DATA_WORKER_TYPES; a down worker is skipped without failing the endpointDepends on the pool-worker and ork PRs that produce and aggregate these alerts.