fix(reporter): keep internal grabber steps and console noise out of reports

[DavertMik]

Closes the report noise reported in the session: I.grabBrowserLogs() calls showing up in the Testomat.io stack, and console/network errors landing as failed steps.

Root cause

Every grabber filter in the codebase was dead code.

CodeceptJS 4's Step has title, not name — actor.js:60 builds new Step(helper, action), and HelperStep sets this.title = action. There is no name property on the class at all (only Section has one). So:

if (step.name?.startsWith('grab')) return;   // step.name is ALWAYS undefined

…never fired, in src/action.ts or src/explorer.ts. It failed open silently, which is why I.grabBrowserLogs() reached both:

• the Testomat.io stack field — test.steps → testData.logs → formatLogs() in the reporter client
• Langfuse step spans — attachStepLogger → tag('step') → SpanDestination

Changes

Internal steps — one predicate, isInternalStep() in src/utils/step-analyzer.ts, reading step.title, replacing three hand-rolled checks that had drifted apart (action.ts filtered grab only, explorer.ts filtered grab+save, rerunner.ts filtered nothing):

• src/action.ts — attachStepLogger
• src/explorer.ts — reported test steps
• src/ai/rerunner.ts — three step handlers that had no filter
• src/utils/logger.ts — Langfuse spans were all named I.step for the same reason; now I.click, I.fillField, …

Console/network errors — addObservation() notes were becoming category: 'user', status: 'failed' steps in the report, so a page logging errors in the background made a passing test read as broken. They are now filtered out of combineStepsAndNotes and out of extractLastNoteMessage (an observation landing last could become the test's headline message), and travel in the test logs instead. Pilot, Analyst and Historian still read them through notesToString() / getLog() unchanged.

Notes for review

Two judgement calls worth a look:

1. Observations were moved to the report's logs/stack rather than dropped, on the grounds that they are real evidence. Easy to drop entirely if a clean stack is preferred.
2. save* is now filtered in attachStepLogger too (it was grab-only there; explorer.ts already filtered both). Harmless — the tester prompt forbids saveScreenshot — but it does change executed-step recording.

Left out deliberately

src/action.ts:589 has the identical dead-property bug:

if (assertionsTarget && ASSERTION_STEP_NAMES.has(step.name)) {

step.name is undefined, so no assertion has ever been captured, meaning output.framework: 'playwright' has been generating tests with zero expect() lines since the CodeceptJS 4 migration. The fix is step.name → step.title on both lines, but it changes generated-test output, so it is not in this PR. Happy to add it here or split it out.

Also unchanged: getPrintableNotes() still renders these to Pilot as FAILED Console error: ….

Verification

bun test tests/unit/ — 1439 pass, 0 fail. Format and lint clean. Three new cases: isInternalStep unit coverage, an explorer test asserting grab/save steps are not recorded while I.click is, and a reporter test asserting observations stay out of report steps.

🤖 Generated with Claude Code