ci(bench): port performance-benchmarking to Gitea native-ci (sccache), scope GitHub to manual#898
Open
AlexMikhalev wants to merge 1 commit into
Open
ci(bench): port performance-benchmarking to Gitea native-ci (sccache), scope GitHub to manual#898AlexMikhalev wants to merge 1 commit into
AlexMikhalev wants to merge 1 commit into
Conversation
…tHub to manual Add .gitea/workflows/benchmark.yml: - Runs on terraphim-native runner with sccache (S3/SeaweedFS backend, env vars matching ci-native.yml exactly) - Triggers on push to main and workflow_dispatch - Runs cargo bench -p terraphim_tinyclaw --bench tinyclaw_benchmarks - Collects Criterion mean estimates into benchmark-results/current-YYYY-MM-DD.json - Regression gate compares against runner-local baseline at ~/.cache/terraphim-bench/baseline.json; fails if any benchmark degrades >20%; seeds baseline from first run (today's date) - Updates baseline automatically on main-branch pushes Scope .github/workflows/performance-benchmarking.yml to manual only: - Remove pull_request: and push: triggers; retain workflow_dispatch: - Add comment explaining the split: Gitea handles CI benchmarks, GitHub workflow kept for deep on-demand analysis and SLO reporting
Contributor
Author
|
compound-review verdict: GO Reviewed by: Carthos (Domain Architect, quality-coordinator) Architecture AssessmentThe boundary between Gitea native-ci (sccache-backed self-hosted runner, push-triggered) and GitHub CI (cloud, manual/on-demand) is clean and well-reasoned. This follows the ADR-0001 pattern already established. FindingsAcceptable (matches established pattern)
Non-blocking recommendation
Informational
Agent PR Checklist
Triggering review chain: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitea/workflows/benchmark.yml: native-ci Criterion benchmark runner + regression gate.github/workflows/performance-benchmarking.ymltoworkflow_dispatchonly (removepush:andpull_request:triggers)What the Gitea workflow does
Runs on the
terraphim-nativerunner with sccache backed by SeaweedFS (S3-compatible, same env config asci-native.yml).Steps:
sccache --start-server+ zero statscargo bench -p terraphim_tinyclaw --bench tinyclaw_benchmarks(Criterion)mean.point_estimatefromtarget/criterion/*/new/estimates.json→benchmark-results/current-YYYY-MM-DD.json~/.cache/terraphim-bench/baseline.jsonon the runner; fail if any benchmark degrades >20%sccache --show-statsWhy baseline stored on runner, not in git
benchmark-results/is in.gitignore. Committing baselines from CI requires force-add and a bot push, which adds noise. Runner-local storage (~/.cache/terraphim-bench/) is simpler and persistent across runs on the same machine.Test plan
benchmarkjob on push to mainworkflow_dispatchworksperformance-benchmarking.ymlno longer auto-triggers on push/PR🤖 Generated with Terraphim AI