[codex] Enable contiguous mul range path without parallel#132
Merged
Conversation
7d6070c to
f6be58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parallelfeatureparallel, while sharing the single-thread runner for both buildsRoot cause
Tenferro uses
strided-kernelwithout theparallelfeature in the benchmark path. The large contiguous-range broadcast-multiply path was gated entirely byparallel, so 1T runs fell back to the generic strided loop for large intermediates.Validation
cargo test -p strided-kernel -- --nocapturecargo test -p strided-kernel --features parallel -- --nocapturecargo fmt --check && git diff --check