Skip to content

Fix dot-general contraction axis order#131

Merged
shinaoka merged 1 commit into
mainfrom
codex/fix-dot-general-contract-order
Jun 6, 2026
Merged

Fix dot-general contraction axis order#131
shinaoka merged 1 commit into
mainfrom
codex/fix-dot-general-contract-order

Conversation

@shinaoka

@shinaoka shinaoka commented Jun 6, 2026

Copy link
Copy Markdown
Member

Summary

  • keep GEMM dimension-group fusion in canonical col-major logical order
  • add a dot_general regression for full contractions where RHS contracting axes are reversed

Verification

  • cargo test -p strided-einsum2 dot_general_full_contract_respects_rhs_contracting_order -- --nocapture
  • cargo fmt --check
  • cargo test -p strided-einsum2 --features faer -- --nocapture
  • cargo test -p strided-kernel --features parallel -- --nocapture
  • cargo llvm-cov --workspace --json --output-path coverage.json && python3 scripts/check-coverage.py coverage.json
  • git diff --check

@shinaoka shinaoka merged commit ae364b9 into main Jun 6, 2026
5 checks passed
@shinaoka shinaoka deleted the codex/fix-dot-general-contract-order branch June 6, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant