Conversation
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
onbjerg
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final-report Prometheus uploads currently wait for each HTTP request to finish before sending the next; baseline-1 in this benchmark run spent roughly ten minutes exporting 375 batches. Partition samples by exported metric name and sanitized labels into bounded upload shards, allowing independent series to upload concurrently while preserving each series' input order across requests.
PROMETHEUS_UPLOAD_WORKERSdefaults to 4; set it to 1 for serial uploads. Encoding remains capped byPROMETHEUS_ENCODE_WORKERS, queues apply backpressure, and HTTP/encoding failures fail finalization. The real-time forwarder is unchanged.Validation:
cargo test -p bench-core: 113 existing tests passed.cargo +nightly fmt --all --checkcargo +nightly clippy -p bench-core --all-targets -- -D warningsThe multi-region benchmark has not been rerun with this change; live speedup depends on series distribution and endpoint capacity.
Prompted by: @shekhirin