fix: ensure deadlock errors in futures fail workflow task immediately#467
Merged
Conversation
Sushisource
approved these changes
Jun 17, 2026
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Makes sense to me. Good find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
If a
Workflow::Futurefails from aDeadlockError, now immediately raise the error instead of storing it until the future is waited upon.This is done by a special marker mixin on the
DeadlockErrorexception.Why?
Previously if a
DeadlockErrorwas thrown in aWorkflow::Futureit would not trigger a WFT failure until the future was waited upon. This could lead to a workflow task completion with a incomplete list of commands emitted. If the history was then replayed on a worker that didn't have CPU contention and didn't trigger the deadlock detector a NDE error would be thrown.Checklist
Addresses [Bug] Sync primitives can lead to un-replayable workflow history. #464
How was this tested:
Added new test that triggers a deadlock detection error in a future.
Any docs updates needed?
N/A