feat: Add optional FIPS support#466
Open
seanarnold wants to merge 1 commit into
Open
Conversation
Opt-in source build (TEMPORALIO_FIPS=1) that links rustls against aws-lc-rs in FIPS mode instead of ring. Default build is unchanged.
Author
|
@Sushisource @chris-olszewski for your review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in source build (TEMPORALIO_FIPS=1) that links rustls against aws-lc-rs in FIPS mode instead of ring. Default build is unchanged.
What was changed
fipsCargo feature on the native extension, driven byTEMPORALIO_FIPS=1at build time. It builds rustls on top ofaws-lc-rsin FIPS mode (for both the gRPC client and the OTLP metric exporter) instead ofring, which isn't FIPS-validated.sdk-coresubmodule to the recentmaincommit that includes the OTLP TLS fix from Feature-select OTLP exporter TLS backend sdk-rust#1333 (without it, the OTLP exporter forcesringin and a ring-free build isn't possible).ring.Why?
Users in FIPS regulated environments currently have to patch the Gem's source to enable FIPS-compliant cryptography. This change pushes it upstream and provides a simple way to compile the gem in a FIPS compatible mode.
Checklist
Closes
How was this tested:
fipsmode on eachringin the built dependency tree (when under fips mode) and fail the job if it's present.README