Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📖 Docs PR preview links
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 649492af8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Has permissions to view [billing](/cloud/billing-and-usage) information and update payment information | ||
| - Otherwise, has the same permissions as Account Read-only users | ||
| - Can be assigned to Service Accounts by a Global Admin, but otherwise can only be assigned by an Account Owner | ||
| - Only an Account Owner can assign Finance Admin to a user, group, or Service Account |
There was a problem hiding this comment.
Carry the Finance Admin restriction into role-update guides
When a Global Admin follows the existing task guidance, docs/cloud/manage-access/users.mdx still says they can update any user's account-level role and identifies only Account Owner as restricted (lines 102–103). The equivalent guides in docs/cloud/manage-access/user-groups.mdx (lines 44, 87–93) and docs/cloud/manage-access/service-accounts.mdx (lines 37, 194–213) likewise tell Global Admins to select or change an account role without this exception. Update those three procedural pages so they do not direct Global Admins toward a Finance Admin assignment that the newly documented rule says they cannot perform.
AGENTS.md reference: AGENTS.md:L234-L242
Useful? React with 👍 / 👎.
Use "role" instead of the undefined "customer role" to match terminology used elsewhere on the page, and cut a sentence that restated what the rest of the paragraph already said.
|
Non-blocking — follow-up needed for consistency This PR documents that Global Admin can never assign Finance Admin, but several other pages still describe Global Admin's role-assignment ability without that carve-out. Filing as non-blocking; we'll ship this PR and address these in a follow-up:
|
Summary
Validation
temporalio/documentationmain.git diff --checkpasses.Made with Cursor