Fix: terminate application process on window close#7
Open
sapph1ren wants to merge 1 commit into
Open
Conversation
Owner
|
Oh, huh, did we not interact with |
Author
|
i guess not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the application enters an infinite loop (
for (;;)) that doesnt check for window close events. This causes the process to remain active in the background (visible in Task Manager) even after the user closes the window.Changes in this PR:
Added
r_loop()to renderer.c to wrapfenster_loop(), allowing the main loop to detect closure.Added
r_close()to properly shut down the fenster window and clean up resources.Updated main.c to use while
(r_loop() == 0)instead of an infinite loop, ensuring a clean exit when the window is closed.