Skip to content

refactor: remove callback nesting from parsers#1477

Closed
mShan0 wants to merge 8 commits into
masterfrom
mark-refactor-parsers
Closed

refactor: remove callback nesting from parsers#1477
mShan0 wants to merge 8 commits into
masterfrom
mark-refactor-parsers

Conversation

@mShan0

@mShan0 mShan0 commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

Continues the refactor of parsers based on #1448.

Refactors the following token parsers:

  • LoginAck
  • Order
  • ReturnStatus
  • Info and Error
  • metadataParse portion of ColumnMetadata

Buffer read functions are in in a separate file/class

@codecov

codecov Bot commented Aug 5, 2022

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 82.58427% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.08%. Comparing base (5015634) to head (a0eebf9).
Report is 62 commits behind head on master.

Files Patch % Lines
src/token/infoerror-token-parser.ts 72.72% 6 Missing ⚠️
src/metadata-parser.ts 92.30% 2 Missing and 2 partials ⚠️
src/token/buffer-reader.ts 92.68% 2 Missing and 1 partial ⚠️
src/token/colmetadata-token-parser.ts 62.50% 3 Missing ⚠️
src/token/loginack-token-parser.ts 83.33% 3 Missing ⚠️
src/token/order-token-parser.ts 78.57% 3 Missing ⚠️
src/token/returnstatus-token-parser.ts 66.66% 3 Missing ⚠️
src/token/returnvalue-token-parser.ts 62.50% 3 Missing ⚠️
src/value-parser.ts 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1477      +/-   ##
==========================================
- Coverage   80.50%   80.08%   -0.43%     
==========================================
  Files          91       92       +1     
  Lines        4669     4750      +81     
  Branches      856      865       +9     
==========================================
+ Hits         3759     3804      +45     
- Misses        634      670      +36     
  Partials      276      276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mShan0
mShan0 force-pushed the mark-refactor-parsers branch from bb0e5d6 to 310b4d4 Compare August 11, 2022 16:51
@mShan0 mShan0 closed this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant