feat: Add toolbar feedback buttons with Sentry feedback form integration#33
Draft
philprime wants to merge 3 commits into
Draft
feat: Add toolbar feedback buttons with Sentry feedback form integration#33philprime wants to merge 3 commits into
philprime wants to merge 3 commits into
Conversation
philprime
force-pushed
the
feature/feedback-button
branch
from
addf073 to
00ae2ba
Compare
philprime
force-pushed
the
feature/feedback-button
branch
from
00ae2ba to
a81e603
Compare
…d UI tests Introduce a FeedbackAction environment value so views call feedback.show() instead of importing SentrySwift directly. Remove the floating feedback widget in favor of toolbar buttons. Adopt the new SentryFeedbackFormConfig API from sentry-cocoa. Add UI tests verifying the feedback button exists and opens the form on all six screens.
philprime
changed the title
📲 Install BuildsiOS
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeedbackActionenvironment value so views callfeedback.show()without importing SentrySwift directlySentryFeedbackFormConfigAPI from sentry-cocoa for manual feedback form presentationshowWidget()) in favor of explicit toolbar buttonsconfigureUserFeedbackTest plan
make test-ui-ios-app, 7/7 green)TESTING=1(Sentry disabled, in-memory DB) so no real feedback is sentmake buildsucceeds