Maintainership question

[deajan]

Hello,

I've improved your vcard tool as a fork at https://github.com/netinvent/csv2vcard
It now can map almost any CSV file through custom nested mapping, has a GUI, windows pre-built executables etc.

I'd like to take over the maintainership if you'd be okay with that.
If so, would you mind allowing "netinvent" organization push new packages to the csv2vcard namespace on PyPI ?
Also, would you mind pointing your README file to the new repo perhaps ?

If you want to keep the vcard tool maintainance, I can make a PR to your repo.
Best regards.

[deajan]

@tech4242 Any chances for this to happen ? If not, I'll have to rename the tool to get a new namespace on PyPI.
Thanks.

[tech4242]

@deajan sorry for not getting back to you. I had lost access to my account on pypi and also neglected this for too long. think of the project as active again and I just pushed v.0.3.0 with some much needed changes. can you check it out and let me know if you have some new ideas or requests? also feel free to open a PR; I promise to check it out asap!

[deajan]

Well, happy that you updated your project, but I think you did not have a look at my fork. I made about 90 commits, including a GUI and of course lots of improvements and fixes.
Sorry but there is way too much differences to make any PR to your upstream.

[tech4242]

@deajan First of all: Merry Christmas 🎅 I just spent some time looking at your work - nice!

I can comfortably bring it over in 3 PRs/releases if you are up for the reviews:

v0.4.0 - Core

• Custom JSON mapping for any CSV format (-m)
• Single-file output - all contacts in one .vcf (--single-vcard)
• Auto-detect file encoding with manual override
• Folder input - batch process all CSVs in a directory
• 15+ new vCard fields: NICKNAME, GENDER, BDAY, ANNIVERSARY, ROLE, NOTE, UID, full N/ADR components

v0.5.0 - Power

• File splitting by size (--max-vcard-file-size) or count (--max-vcards-per-file)
• Multi-type fields: TEL (CELL/FAX/VOICE/...), EMAIL (HOME/WORK), ADR (HOME/WORK)
• Photo/Logo/Key embedding (base64 or URL)
• Accent stripping for compatibility (--strip-accents)
• Validation for email, gender, geo coordinates
• Extra fields: CATEGORIES, GEO, TZ, KEY

v0.6.0: GUI => here I would diverge and useTextual instead of tkinter and make it optional like this: pip install csv2vcard[tui]

I will also try to maintain the 85%+ code coverage. shouldn't be a big deal

My suggestion: you let me try the first PR and then you make up your mind :)

[deajan]

@tech4242 Happy holidays too ;)

I am happy if you can take time to merge back my fork into your upstream project and keep maintainership.
I've just updated my repo into a usable state since the GUI framework changed source between 2023 and now.

As for the GUI, I provided prebuilt Windows executables with a "native" gui interface. Not a big tkinter fan either but FreeSimpleGUI really makes GUI developpment quick and easy. I'd highly advocate to keep it since it's more appealing that a text based GUI.

Feel free to ping me whenever you have a PR ready.

[tech4242]

@deajan 🎁 as it turns out, I was already a bit bored and the PR comes on time :) #4

[deajan]

I've had a look at your PR.
From what I read sofar, you decided to rewrite the vcard as a class model, and backported mappings which looks great.
TBH, it's alot of work to read and understand code that has been written with backporting in mind by someone else.

I'll make you another proposal. Have your PRs done, and ping me so I can take csv2vcard for some test drives with input / outputs that worked for me earlier.

[tech4242]

I've had a look at your PR. From what I read sofar, you decided to rewrite the vcard as a class model, and backported mappings which looks great. TBH, it's alot of work to read and understand code that has been written with backporting in mind by someone else.

I'll make you another proposal. Have your PRs done, and ping me so I can take csv2vcard for some test drives with input / outputs that worked for me earlier.

Hi @deajan, I kind of get it :) this includes everything except the GUI: #5 since that is easy to add. I guess you can QA that branch with your workflows (I merged v0.4.0 already) and then I can add the new GUI based on your feedback

[tech4242]

@deajan itching to close this up :))

[tech4242]

@deajan doing a final loop with you and merging in any case in a couple of days. hope to do it with your feedback 🙌

[tech4242]

Closing this one due to inactivity. Everything is done except UI which I would add if anyone else requests it