Incorrect Parameters in OpenAPI Spec - #5
Open
davidmayr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were attempting to use a very strict OpenAPI generator, but the generation failed due to certain path parameters being incorrect. I updated the definitions and generation works fine on the generator we use now.
categoryId was duplicated because that's how it was handled everywhere else in the schema too. It should likely receive its own definition like basketIdent has in the future, but I left it as is for now.
Generation was not re-run as the output was also not updated with the last commit to the repository, so the diff would be quite large with unrelated changes.