Serialize Velocity command dispatch - #161
Open
MachoPiggies wants to merge 2 commits into
Open
Conversation
…hat velocity didn't have this even before my original commit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160
Summary
This change serializes command dispatches on the Velocity platform by chaining the
CompletableFuturereturned fromCommandManager#executeAsync.Previously,
dispatchCommandinvokedexecuteAsync(...)and immediately returned, allowing multiple Tebex commands to execute concurrently. This could result in later commands completing before earlier ones, depending on their execution time.By adding an internal
CompletableFuturechain, each command waits for the previous command to complete before execution begins, whilst still preserving thedispatchCommandAPI.This resolves a race condition where multiple Tebex commands dispatched in quick succession (for example, purchase followed immediately by remove during test payments) could complete out of order. The implementation is intentionally minimal and only affects the Velocity platform.