[sync] fix v2 trash field restore#3442
Conversation
Synced from teableio/teable-ee@c67c087 Co-authored-by: Aries X <caoxing9@gmail.com> Co-authored-by: Bieber <artist@teable.io> Co-authored-by: Boris <boris2code@outlook.com> Co-authored-by: Jocky Zhou <jocky@teable.ai> Co-authored-by: Jun Lu <hammond@teable.io> Co-authored-by: Pengap <penganpingprivte@gmail.com> Co-authored-by: SkyHuang <sky.huang.fe@gmail.com> Co-authored-by: Uno <uno@teable.ai> Co-authored-by: nichenqin <nichenqin@hotmail.com>
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0e55f3feb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @Param('tableId') tableId: string, | ||
| @Body(new ZodValidationPipe(copyByIdRoSchema), TqlPipe) copyRo: ICopyByIdRo | ||
| ): Promise<ICopyVo> { | ||
| return this.selectionService.copyById(tableId, copyRo); |
There was a problem hiding this comment.
When this new by-id endpoint is called through a share view, it bypasses ShareViewScopeService and passes client-supplied record/field ids directly to copyById; unlike the range copy/paste/clear/delete paths, nothing checks that the ids are visible/writable in the shared view. A share-view user can therefore post arbitrary hidden record or field ids and read data outside the shared view, and the same scope check is needed for the new paste/clear/delete by-id routes below.
Useful? React with 👍 / 👎.
🧹 Preview Environment Cleanup
|
2 participants
🔄 Automated sync from EE repository.
207 commit(s) synced since last sync.
Authors
Included commits
ai-agent-engineT5222 T3933 (Pengap)Latest source commit: teableio/teable-ee@c67c087
This PR was automatically created by the sync workflow.