Skip to content

Taylor sills#1

Open
tdsills wants to merge 12 commits into
masterfrom
taylor-sills
Open

Taylor sills#1
tdsills wants to merge 12 commits into
masterfrom
taylor-sills

Conversation

@tdsills
Copy link
Copy Markdown
Owner

@tdsills tdsills commented Feb 2, 2021

Hey Matt,

Here are my exercises. I had issues with some, but I tried to get something for everything.

Thanks,

Taylor

@tdsills tdsills requested a review from a user February 2, 2021 22:03
Comment thread exercise-1.js
console.log("TEK");
} if (i % 5 === 0) {
console.log("camp");
} if (i % 3 === 0 && i % 5 === 0) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really don't want to have more than one "if" statement at a time. Generally, we would want to use "if else" and "else" after the first if. Multiple "if" statements can cause bugs.

Comment thread exercise-1.js
// Write a function that returns a car object using some given info about your car. Required inputs are the make, model, year, and color.

//your code...
let myCar = {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to create a "parent" car object here that we use as a template for your "myCar" object. I'm also confused why you are only printing the "make" property instead of the entire car.

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Taylor. I can tell you really gave MAXIMUM EFFORT on these exercises. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant