Skip to content

Add mutex for writing to result#29

Open
kylecarbs wants to merge 1 commit into
tcnksm:masterfrom
kylecarbs:master
Open

Add mutex for writing to result#29
kylecarbs wants to merge 1 commit into
tcnksm:masterfrom
kylecarbs:master

Conversation

@kylecarbs

Copy link
Copy Markdown

Fixes #21.

@kylecarbs

Copy link
Copy Markdown
Author

@tcnksm can we merge this?

@randombangaloreguy

Copy link
Copy Markdown

This fix seems to have been pending for a while. @kylecarbs, could you please merge it at your earliest convenience? Thank you!

@kylecarbs

Copy link
Copy Markdown
Author

@randombangaloreguy only those with write access can!

@randombangaloreguy

Copy link
Copy Markdown

Thanks for pointing that out, @kylecarbs. @tcnksm, since you have write access, could you please take a look and merge the fix when you have a chance? Appreciate your help!

@randombangaloreguy randombangaloreguy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the change on top of v0.2.0.

@josharian

Copy link
Copy Markdown

This causes a bunch of go vet failures. Unfortunately, Result is a value type and can't have a mutex added to it. But a local mutex ought to do? It'd be nice to have a test, too. But this is not my project, I'm just a bystander.

For anyone else finding this, the failures require HTTP/2 to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

race conditions writing to Result

3 participants