run/logs: tail >32 array pager via resolog#16
Merged
Conversation
Final integration step. The large-array pager (size > maxTailedChildren) now
tails each visible page through resolog instead of the home-grown GetLogEvents
loop: a per-page resolog.Tail over windowSources (one "batch[N]" Source per
child in the window) + childSink. Switching pages cancels the current window's
tail and starts the next; the parallel status loop keeps [STATUS], the progress
bar, the final JobDetail and exit-on-FAILED. Off-terminal it falls back to
progress-only, as before.
No resolog change needed: a bounded 32-child window keeps the per-child fan-in
under the FilterLogEvents TPS quota, so batching (multi-stream sources) is
deferred. tailOnce now backs only the logs no-follow one-shot dump.
childTail trimmed to {id, stream}. Tests: TestWindowSources (window source
emission); existing pager/array tests green; full -race green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final integration step (PR-4). The large-array pager now tails through resolog too — completing the swap of batchkoi's CloudWatch tailing onto resolog.
What changes
For arrays
> maxTailedChildren(32), the interactive pager UI is unchanged (windows, arrow keys, raw mode, progress bar), but the fetch moves to resolog:resolog.TailoverwindowSources(aResolutionthat emits onebatch[N]Source per child in the window as its stream appears) +childSink.[STATUS], the progress bar, the finalJobDetailand exit-on-FAILED. Off-terminal → progress-only (unchanged).Why no resolog change
A bounded 32-child window keeps the per-child fan-in under the FilterLogEvents TPS quota, so the "see all children at once" firehose / multi-stream batching is deliberately not built (it would overwhelm output anyway). Paging stays the readable, TPS-safe model.
tailOncenow backs only thelogsno-follow one-shot dump.Tests
TestWindowSources(window Source emission incl. labels/streams/group).-racegreen; dependency-hygiene gate still clean (no sfn/lambda).Note on coverage
The interactive pager path needs a TTY, so (as before this PR) it isn't exercised end-to-end in CI; the testable core (
windowSources,childSink) is unit-tested.🤖 Generated with Claude Code