Repository navigation
fix(cli): box the stale-pin notice, and tell agents to run init from --help - #470
Merged
Merged
Conversation
…--help The notice that package.json pins an older Taskless CLI now draws in the same orange box as the restart-your-agents banner, so it is not lost in the install output. The box moves to install/notice-box.ts and both notices render through it; list items wrap under their own text and a nightly version is never split across rows. Every --help now opens with a line telling an agent that wants to install or update Taskless to run init first, named with getCliPrefix() so a pinned nightly points at itself.
Member
Author
|
@claude /review |
|
Claude finished @theCodeDrift's task in 10m 36s —— View job Review mode: incremental — read 0 prior review thread(s) before reviewing.
Assessment[New] I found nothing new to flag. This is a clean, well-scoped refactor + feature:
No correctness, security, performance, or test-adequacy issues found. No inline comments posted. |
Member
Author
Thanks. The review found no issues and left no inline comments, so there are no changes to make. — AI Coding Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to what an agent sees while installing or updating Taskless.
The stale-pin notice is boxed. When
initfinds apackage.jsonpin of@taskless/clior@taskless/cli-nightlyolder than the CLI that just ran, it now prints the notice in the same orange box as the restart-your-agents banner, headed UPDATE PINNED TASKLESS VERSIONS. Before, it was plain lines that were easy to lose among the rest of the install output. The box drawing moves out ofreload-notice.tsintosrc/install/notice-box.ts, and both notices render through it. Pins render as a bulleted list whose items wrap under their own text. A nightly version is never split across rows, so it stays copyable.describePinnow returns the pin without its-bullet, because the box adds its own.infoadds the bullet itself, so its output is unchanged.Every
--helpopens with a line for agents:<cli>comes fromgetCliPrefix(), the same function every error remedy uses. It names the launcher that was used and this exact build, so a pinned nightly points at itself:npx @taskless/cli-nightly@<that version> init. Floating to@latestwould move someone onto a different nightly from the one they chose. The line goes on every--help, not just the top-level one, because an agent may start from a subcommand's help.Verification
pnpm typecheck,pnpm lintandpnpm test(2101/2101) pass.build:nextnightly build. The nightly names@taskless/cli-nightly@0.12.0-next-<sha>.--helpandauth login --help.