Repository navigation
docs(changeset): say BasedOnStyles is rejected with any value - #377
Merged
Merged
Conversation
The vale-config-schema changeset still described the pre-3.22.0 rule (a non-empty value is rejected) while vale-3-22-0.md says the key is rejected outright. Both ship in 0.11.3; make them agree. Raised in the #368 review.
theCodeDrift
added
the
skip-changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One phrase in
.changeset/vale-config-schema.md: "a non-emptyBasedOnStyles" → "aBasedOnStylesassignment with any value".Why
That changeset described the rule as #365 shipped it. #368 (Vale 3.22.0) then made the schema reject the key outright and said so in
.changeset/vale-3-22-0.md. Both notes ship in 0.11.3, so without this they contradict each other in the same release. Raised by the review on #368.Edits an existing changeset; adds none.