Unacceptable TypeScript detection#241
Open
knocte wants to merge 27 commits into
Open
Conversation
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
30 times, most recently
from
cd3d681 to
6697459
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
08c752b to
07007d5
Compare
Unacceptable TypeScript work in progress. NB: git clean -fdx had to be added in sanity check because otherwise it could fail with: ``` ./packages/fsharpx.collections/3.1.0/fable/Deque.fs has been written. Processing ./packages/fsharpx.collections/3.1.0/fable/Collections.fs The following exception occurs while formatting stdin: Fantomas.FormatConfig+FormatException: Formatted content is not valid F# code at Fantomas.Extras.FakeHelpers.formatContentInternalAsync@86-5.Invoke(Boolean isValid) in /_//src/Fantomas.Extras/FakeHelpers.fs:line 87 at Microsoft.FSharp.Control.AsyncPrimitives.CallThenInvokeNoHijackCheck[a,b](AsyncActivation`1 ctxt, b result1, FSharpFunc`2 userCode) in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 464 at Microsoft.FSharp.Control.Trampoline.Execute(FSharpFunc`2 firstAction) in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 104 --- End of stack trace from previous location --- at Microsoft.FSharp.Control.AsyncResult`1.Commit() in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 391 at Microsoft.FSharp.Control.AsyncPrimitives.QueueAsyncAndWaitForResultSynchronously[a](CancellationToken token, FSharpAsync`1 computation, FSharpOption`1 timeout) in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1044 Formatted content is not valid F# code at Microsoft.FSharp.Control.AsyncPrimitives.RunSynchronously[T](CancellationToken cancellationToken, FSharpAsync`1 computation, FSharpOption`1 timeout) in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1070 at Microsoft.FSharp.Control.FSharpAsync.RunSynchronously[T](FSharpAsync`1 computation, FSharpOption`1 timeout, FSharpOption`1 cancellationToken) in D:\a\_work\1\s\src\fsharp\FSharp.Core\async.fs:line 1365 at Program.processSourceString(Boolean isFsiFile, String s, FSharpChoice`2 tw, FormatConfig config) in /_//src/Fantomas.CoreGlobalTool/Program.fs:line 129 at Program.stringToFile@343(Boolean force, Boolean profile, String s, String outFile, FormatConfig config) in /_//src/Fantomas.CoreGlobalTool/Program.fs:line 355 Error: Process completed with exit code 1. ```
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
07007d5 to
5eddc03
Compare
Otherwise devs working on local clone wouldn't benefit from it.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
19a7248 to
a93e3c3
Compare
It would be a failing test for now.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
acf0517 to
14044d9
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
3 times, most recently
from
decfea6 to
b029208
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
6d3a545 to
0fbf7d4
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
3 times, most recently
from
e2c959e to
5740e0f
Compare
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
4 times, most recently
from
47f1c26 to
e69e314
Compare
knocte
changed the title
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
2 times, most recently
from
303c10d to
15b6372
Compare
It is in fp-sdk already and we forgot to remove it from here.
knocte
force-pushed
the
wip/unacceptableTypeScript
branch
from
83f3bd8 to
85b5583
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.