Prevent drag-and-drop filename option injection - #43
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
Leafpad rebuilt a command-line string from dropped filenames and reparsed it before spawning additional editor instances. A filename containing a newline could inject --gtk-module and load an attacker controlled GTK module. Pass the filename as an argv element to g_spawn_async so filename characters cannot become additional command-line options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leafpad builds a command-line string from dropped filenames and launches additional instances with
g_spawn_command_line_async. A filename containing a newline can inject a separate GTK option such as--gtk-moduleand load attacker-controlled native code.This changes multi-file drag-and-drop to call
g_spawn_asyncwith an argv array, keeping the filename as one argument.Validated with argv-injection and GTK module-loading probes.