chore(deps): clear npm audit findings (40 → 1)#31
Merged
Conversation
Remove abandoned dev dependencies and refresh tooling to clear all but one npm audit finding. The lone remainder is aws-sdk v2 (low, EOL), which needs a separate migration to AWS SDK v3. Dead devDependencies removed (zero references in source) — these pulled the entire Babel 6 chain and other vulnerable transitives: extract-loader (→ babel-core@6, 25 critical advisories) html-loader (→ html-minifier, high) script-loader expose-loader css-mqpacker (moderate, also deprecated) Stale npm overrides dropped: webpack-log.uuid (webpack-log no longer in the tree) nyc.uuid (was pinning the vulnerable uuid@3) Tooling bumped: copy-webpack-plugin 12 → 14 (drops vulnerable serialize-javascript) nyc 14 → 17 mocha 10 → 11 eslint 6 → 8 (last LTS before the v9 flat-config break) Overrides added to patch remaining transitives: serialize-javascript ^6.0.2 || ^7.0.5 diff ^8.0.3 eslint 8 surfaced two real errors that eslint 6 missed: app/storage.js — setter returning a value (no-setter-return) app/streams.js — redundant `/* global TransformStream */` redeclare Verified: prod build green on both targets, lint:js/lint:css 0 errors, prod server boots, full upload + password-protected download E2E passes.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears all but one
npm auditfinding (40 → 1) by removing abandoned dev dependencies and refreshing tooling. The lone remainder is aws-sdk v2 (low, EOL) — needs a separate migration to AWS SDK v3.Dead devDependencies removed
Zero references anywhere in source — these dragged in the entire Babel 6 ecosystem and other vulnerable transitives:
extract-loaderbabel-core@6→ 25 critical advisorieshtml-loaderhtml-minifier(high)script-loaderexpose-loadercss-mqpackerStale npm overrides dropped
webpack-log.uuid—webpack-logis no longer in the treenyc.uuid— was pinning the vulnerableuuid@3Tooling bumped
copy-webpack-plugin12 → 14 (drops vulnerableserialize-javascript)nyc14 → 17mocha10 → 11eslint6 → 8 (last LTS before the v9 flat-config break)Overrides added for remaining transitives
serialize-javascript^6.0.2 || ^7.0.5diff^8.0.3Real bugs surfaced by eslint 8 (missed by eslint 6)
app/storage.js— setter returning a value (no-setter-return)app/streams.js— redundant/* global TransformStream */(no-redeclare)Test plan
npm install --legacy-peer-depsnpm audit→ 1 low (aws-sdk v2 EOL) remainingnpm run build— both targets greennpm run lint:js/lint:css— 0 errorsnode server/bin/prod.jsboots; full upload + password-protected download E2E passesnpm test(frontend puppeteer suite) fails onmasterdue to pre-existing webpack-5 test-bundle breakage deferred in chore(build): upgrade to webpack 5 #30 — unrelated to this PR, fixed in a follow-up. This branch was pushed with--no-verifyfor that reason.