enhance(docker): mount templates volume so page refresh uses changed template#145
Open
wesleyboar wants to merge 1 commit into
Open
enhance(docker): mount templates volume so page refresh uses changed template#145wesleyboar wants to merge 1 commit into
wesleyboar wants to merge 1 commit into
Conversation
wesleyboar
changed the title
Mounts ./service/templates into the authenticator container so templates can be edited and refreshed without rebuilding the image.
wesleyboar
force-pushed
the
dx-mount-templates-volume
branch
from
90763cf to
0f66b07
Compare
Collaborator
|
This alone didn't enable hot reload, I also had to add this at line 26 in models.py: |
wesleyboar
changed the title
Contributor
Author
|
@gcurbelo123, true. I shouldn't have said "live reload". I've renamed the PR to instead describe accurately what it does. My intent was not automatic reload, but just to make page refresh result in latest template. |
wesleyboar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When developing locally, template edits should be reflected on page after page refresh without needing to rebuild the image, so I mount the local
./service/templatesdirectory into theauthenticatorcontainer.Warning
If the committed
docker-compose.ymlis used on production, then decline this PR. I can instead document this solution or offer it via adocker-compose.local.py.Changes
./service/templatesvolume mount toauthenticatorservice indocker-compose.ymlTesting
service/templates/UI
Test.Docker.Volume.Mount.of.Templates.mov