🧪 [testing improvement] Fix invalid signature length check in schnorr#32
🧪 [testing improvement] Fix invalid signature length check in schnorr#32tanm-sys wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| let result = Schnorr::<Secp256k1, Sha256>::signature_from_bytes(&invalid_bytes_long); | ||
| assert!(result.is_err()); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
CRITICAL: Missing newline at end of file
The file ends without a trailing newline character, which is a common source of diff noise and can cause issues with some tools.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
|
| let invalid_bytes_long = vec![0u8; 65]; | ||
| let result = Schnorr::<Secp256k1, Sha256>::signature_from_bytes(&invalid_bytes_long); | ||
| assert!(result.is_err()); | ||
| } |
There was a problem hiding this comment.
CRITICAL: Missing newline at end of file
The file ends without a trailing newline character, which is a common source of diff noise and can cause issues with some tools.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 file)
Reviewed by laguna-m.1-20260312:free · 442,128 tokens |
1 participant
🎯 What: The testing gap addressed
The length check for schnorr signatures when decoding from bytes incorrectly checked for lengths
< 64instead of!= 64. Thus any slice longer than 64 bytes passed the length check and would subsequently cause undefined or panic behavior.📊 Coverage: What scenarios are now tested
A test has been added to test that arrays with
length != 64(both less and greater) returnErr(Error::InvalidSignature).✨ Result: The improvement in test coverage
The module
schnorrtests now provide coverage for this bug and prevent regressions for invalid signature sizes during initialization.PR created automatically by Jules for task 16239060179232518180 started by @tanm-sys