Point two pilot-table intake files at where those factories live now - #2160
Closed
andrewboudreau wants to merge 1 commit into
Closed
Point two pilot-table intake files at where those factories live now#2160andrewboudreau wants to merge 1 commit into
andrewboudreau wants to merge 1 commit into
Conversation
main is red on `tools/check_dead_references.py`, and has been since #2127 landed: FAIL: 2 prose reference(s) name a path that does not exist: notes/tu-filename-reconstruction-pilot.md names `src/FlyGuy_Spawn.c`, which is not in the tree notes/tu-filename-reconstruction-pilot.md names `src/WaterfallMist_Spawn.cpp`, which is not in the tree Neither PR was wrong on its own. #2127's pilot table was written against the tree as it stood, and the TU promotions that deleted those two files were in flight beside it -- two green PRs, one red main. Every open PR now inherits the failure through its merge-with-main check. The table's second column is headed "Current intake file", so the fix is to name the file each factory lives in today rather than to bank the dead paths: `WaterfallMist_Spawn` was folded into `src/actors/d_a_obj_waterfall.cpp` and `FlyGuy_Spawn` into `src/actors/daPropeller_Heyho_c.cpp` (ROM ordinal 26 there). Both were checked by grep, not assumed. Every other row in the table still names a live file. Prose only -- no build input is touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FsXWgEM3Gtbqs6zEdwLMYV
✅ PR validation — Passednoverify: no source/build-data changes in this PR Each changed |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red ontools/check_dead_references.py, and has been since #2127 landed:Reproduced on a clean checkout of
3d4377d61, so this is not a branch artifact.Neither PR was wrong on its own. #2127's pilot table was written against the tree as it
stood, and the TU promotions that deleted those two files were in flight beside it — two
green PRs, one red
main. Every open PR now inherits the failure through itsmerge-with-
maincheck; it is what turned #2148 red, and #2130, #2151 and #2156 arebehind it too.
The fix
The table's second column is headed "Current intake file", so the honest fix is to
name the file each factory lives in today rather than to bank the dead paths in
config/dead-reference-baseline.json:WATERFALLsrc/WaterfallMist_Spawn.cppsrc/actors/d_a_obj_waterfall.cppPROPELLER_HEYHOsrc/FlyGuy_Spawn.csrc/actors/daPropeller_Heyho_c.cppBoth were checked by grep, not assumed —
WaterfallMist_Spawnis defined in the waterfallTU, and
FlyGuy_Spawnis ROM ordinal 26 indaPropeller_Heyho_c.cpp. Every other row inthe table still names a live file.
Prose only; no build input is touched.
check_dead_referencespasses on the branch.🤖 Generated with Claude Code
https://claude.ai/code/session_01FsXWgEM3Gtbqs6zEdwLMYV