Reconstruct five KM2/KM3 actor profiles (wave 23) - #2158
Merged
Conversation
✅ PR validation — PassedCommitted merge introduces no reconstruction or attribution regression. Full merge validation
Byte-verified means the range carries Per-file link-check detailAll 28 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.
The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate. |
andrewboudreau
marked this pull request as ready for review
September 2, 2026 05:11
notes/tu-reconstruction-pilot-report.md quotes a verbatim build_pin.verify log from before src/PoleLift_Spawn.c was renamed to src/daObjWlPolelift_c_classInit.cpp; the log output shouldn't be rewritten, so mark the path as a known historical reference.
…ction-wave23 # Conflicts: # config/arm9/overlays/ov045/symbols.txt # config/arm9/overlays/ov047/delinks.txt # config/arm9/overlays/ov047/symbols.txt # include/daObjKm3_Kuruma_c.h # notes/data/c-cpp-classification.tsv # notes/data/tu-merge-candidates.json # src/daObjKm3_Kuruma_c_classInit.c # symbols/actor_renames.tsv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconstructs five ROM-evidenced actor profile/factory pairs: KM2_GURA, KM2_AMI_BOU, KM2_UKISHIMA, KM2_NOBIRU, and KM3_KURUMA. Historical community aliases remain recorded in symbols/actor_renames.tsv and source provenance comments. Exact original SM64DS spellings are not claimed.\n\nValidation: five strict relocation-aware factory matches; 32/32 changed-source and header consumers VERIFIED; PoleLift shadow TU 7/7 exact; 98/98 shadow TUs compile; all 1,190 shadow references resolve; attribution and port references intact; 11,088/11,088 source functions and 4/4 source data claims reproduce; 106/106 modules exact.