Skip to content

Reconstruct five LLL profile pairs - #2145

Merged
andrewboudreau merged 3 commits into
mainfrom
cpp/profile-reconstruction-wave13
Sep 2, 2026
Merged

Reconstruct five LLL profile pairs#2145
andrewboudreau merged 3 commits into
mainfrom
cpp/profile-reconstruction-wave13

Conversation

@andrewboudreau

Copy link
Copy Markdown
Collaborator

Stacked on #2144.

Reconstructs the registry-facing factory/profile pairs for FL_AMILIFT, FL_MARUTA, FL_RING, FL_GURA, and FL_LONDON:

  • daObjFl_Amilift_c_classInit / g_profile_FL_AMILIFT
  • daObjFlMaruta_c_classInit / g_profile_FL_MARUTA
  • daObjFl_Ring_c_classInit / g_profile_FL_RING
  • daObjFl_Gura_c_classInit / g_profile_FL_GURA
  • daObjFl_London_c_classInit / g_profile_FL_LONDON

These preserve the separation between ROM RTTI class identity and the existing community implementation aliases MetalNetLift, RollingLogLll, VolcanoRing, TiltingPlatformLll, and LavaBridge. Exact original SM64DS spellings are not claimed, and no source-owned profile descriptor data is invented.

Validation: all five factories match 2004/b56 with strict relocation checks; all 32 affected sources are VERIFIED; five history-preserving path moves keep attribution intact; 98/98 reconstructed TUs compile; 11,088/11,088 source functions and 4/4 source data claims reproduce; 106/106 modules exact; repository reference, attribution, compatibility, language-mode, eligibility, ROM-data, and dead-reference gates pass.

@tangos-validator

tangos-validator Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ PR validation — Passed

Committed merge introduces no reconstruction or attribution regression.

Full merge validation

Check Result
Committed test merge yes
Byte-verified functions 10,655 / 11,347 (93.90%, +0)
Byte-verified code bytes 1,989,784 / 2,211,124 (89.99%, +0)
Claimed, not byte-verified 562 functions, 115,896 bytes (+0)
Perfect source moves 0 R100
Enrolled ranges (delinks complete) 11,059 functions, 2,053,148 bytes (92.86%, +0) -- differs from byte-verified by +404
Contributor credit 0 added, 0 changed, 0 lost
Relocation check 32 checked; 32 VERIFIED
Port reference check 405 checked; 0 stale
Module fidelity 106/106 exact; 100.000000% compared bytes
Code linked from verified source 11,088 functions, 2,067,148 bytes (93.49%)
Module bytes from source 2,067,148 / 3,049,600 (67.8%); 811,492 (26.6%) are data no delink entry reaches
ROM data reproduced from source 589 symbol(s) exact, 172 partial, 5 differ

Byte-verified means the range carries complete in a delinks.txt, so the ROM build compiled it and compared it to the cartridge. The 562 claimed functions have a src/ file named after the symbol with no NONMATCHING banner, and nothing compiles them -- dsd fills their addresses with the ROM's own bytes. Both together are the 11,217 this project calls matched.

Per-file link-check detail

All 32 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.

File Symbol Result Slots checked
src/_ZN10LavaBridge13InitResourcesEv.cpp _ZN10LavaBridge13InitResourcesEv ✅ verified 1
src/_ZN10LavaBridge16CleanupResourcesEv.cpp _ZN10LavaBridge16CleanupResourcesEv ✅ verified 1
src/_ZN10LavaBridge6RenderEv.cpp _ZN10LavaBridge6RenderEv ✅ verified 1
src/_ZN10LavaBridge8BehaviorEv.cpp _ZN10LavaBridge8BehaviorEv ✅ verified 1
src/_ZN10LavaBridgeD0Ev.cpp _ZN10LavaBridgeD0Ev ✅ verified 1
src/_ZN10LavaBridgeD1Ev.cpp _ZN10LavaBridgeD1Ev ✅ verified 1
src/_ZN11VolcanoRing13InitResourcesEv.cpp _ZN11VolcanoRing13InitResourcesEv ✅ verified 1
src/_ZN11VolcanoRing16CleanupResourcesEv.cpp _ZN11VolcanoRing16CleanupResourcesEv ✅ verified 1
src/_ZN11VolcanoRing6RenderEv.cpp _ZN11VolcanoRing6RenderEv ✅ verified 1
src/_ZN11VolcanoRing8BehaviorEv.cpp _ZN11VolcanoRing8BehaviorEv ✅ verified 1
src/_ZN11VolcanoRingD0Ev.cpp _ZN11VolcanoRingD0Ev ✅ verified 1
src/_ZN11VolcanoRingD1Ev.cpp _ZN11VolcanoRingD1Ev ✅ verified 1
src/_ZN12MetalNetLift13InitResourcesEv.cpp _ZN12MetalNetLift13InitResourcesEv ✅ verified 1
src/_ZN12MetalNetLift16CleanupResourcesEv.cpp _ZN12MetalNetLift16CleanupResourcesEv ✅ verified 1
src/_ZN12MetalNetLift6RenderEv.cpp _ZN12MetalNetLift6RenderEv ✅ verified 1
src/_ZN12MetalNetLift8BehaviorEv.cpp _ZN12MetalNetLift8BehaviorEv ✅ verified 1
src/_ZN12MetalNetLiftD0Ev.cpp _ZN12MetalNetLiftD0Ev ✅ verified 1
src/_ZN12MetalNetLiftD1Ev.cpp _ZN12MetalNetLiftD1Ev ✅ verified 1
src/_ZN13RollingLogLll13InitResourcesEv.cpp _ZN13RollingLogLll13InitResourcesEv ✅ verified 1
src/_ZN13RollingLogLll16CleanupResourcesEv.cpp _ZN13RollingLogLll16CleanupResourcesEv ✅ verified 1
src/_ZN13RollingLogLll8BehaviorEv.cpp _ZN13RollingLogLll8BehaviorEv ✅ verified 1
src/_ZN13RollingLogLllD0Ev.cpp _ZN13RollingLogLllD0Ev ✅ verified 1
src/_ZN13RollingLogLllD1Ev.cpp _ZN13RollingLogLllD1Ev ✅ verified 1
src/_ZN18TiltingPlatformLll13InitResourcesEv.cpp _ZN18TiltingPlatformLll13InitResourcesEv ✅ verified 1
src/_ZN18TiltingPlatformLll16CleanupResourcesEv.cpp _ZN18TiltingPlatformLll16CleanupResourcesEv ✅ verified 1
src/_ZN18TiltingPlatformLllD0Ev.cpp _ZN18TiltingPlatformLllD0Ev ✅ verified 1
src/_ZN18TiltingPlatformLllD1Ev.cpp _ZN18TiltingPlatformLllD1Ev ✅ verified 1
src/daObjFlMaruta_c_classInit.c daObjFlMaruta_c_classInit ✅ verified 1
src/daObjFl_Amilift_c_classInit.c daObjFl_Amilift_c_classInit ✅ verified 1
src/daObjFl_Gura_c_classInit.c daObjFl_Gura_c_classInit ✅ verified 1
src/daObjFl_London_c_classInit.c daObjFl_London_c_classInit ✅ verified 1
src/daObjFl_Ring_c_classInit.c daObjFl_Ring_c_classInit ✅ verified 1

The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate.

@andrewboudreau
andrewboudreau marked this pull request as ready for review September 2, 2026 05:04
Base automatically changed from cpp/profile-reconstruction-wave12 to main September 2, 2026 08:07
@andrewboudreau
andrewboudreau merged commit 0304de0 into main Sep 2, 2026
9 checks passed
@andrewboudreau
andrewboudreau deleted the cpp/profile-reconstruction-wave13 branch September 2, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant