minigames: convert dScMgBSC_c, dScMgCard_c, dScMgMCarlo_c to real C++ members - #2122
Closed
andrewboudreau wants to merge 1 commit into
Closed
minigames: convert dScMgBSC_c, dScMgCard_c, dScMgMCarlo_c to real C++ members#2122andrewboudreau wants to merge 1 commit into
andrewboudreau wants to merge 1 commit into
Conversation
✅ PR validation — PassedCommitted merge passes; 33 contributor credit reassignment(s) noted, not a blocker. Full merge validation
Contributor credit moved (33)
+8 more; the full list is in the JSON report's Byte-verified means the range carries Warnings: contributor attribution changed, not a blocker (33 changed, 0 lost -- src/actors/dScMgCard_c.cpp: andrewboudreau -> github-actions[bot]; src/actors/dScMgCard_c.cpp: andrewboudreau -> github-actions[bot]; src/actors/dScMgCard_c.cpp: andrewboudreau -> github-actions[bot]; +30 more). Per-file link-check detailAll 7 changed file(s) compile to the ROM byte-for-byte with correct relocation targets.
The private worker commits a test merge, builds the stock ROM profile, compares every executable module, measures matched and source-built code, checks contributor lineage, and verifies affected relocations. The mod profile is opt-in and is not part of this merge gate. |
andrewboudreau
force-pushed
the
constitution-lane
branch
from
September 1, 2026 13:47
b4dc998 to
4c88c12
Compare
andrewboudreau
added
the
attribution-override
andrewboudreau
force-pushed
the
constitution-lane
branch
from
September 1, 2026 14:17
4c88c12 to
00c813c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-cut on current
mainas one source-only commit. The old draft's tools, CI, notes, claims, and match-ledger changes are no longer in this PR.Conversions
dScMgBSC_c: 19-function promoted TU; 17 real members and noextern "C"definitions.dScMgCard_c: 34-function promoted TU; 30 real members plus the two byte/order-required element D1 destroy stubs.dScMgMCarlo_c: 23-function promoted TU; 20 real members plus the byte/order-required element D1 destroy stub.main's family declarations: slot 18 isvoid, and slot 21OnGroundPoundedis avoidvirtual override.The renamed state/helper methods whose ROM symbols were address-only remain explicitly marked as coined in
symbols/actor_renames.tsvand the TU manifests.Verification on the recut head
This remains draft until the refreshed private ROM validation finishes on this exact head.