Scope TU span checks to text sections - #2121
Merged
Merged
Conversation
✅ PR validation — Passednoverify: no source/build-data changes in this PR Each changed |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-cut of #2109 as requested in review: one commit directly on current main, with no unrelated stack ancestry.
span_entries now selects candidate contributions by .text only, so a neighbouring intact TU with later .data cannot make an adjacent text contribution look straddling. The existing fail-closed rule is retained: if a selected legacy entry itself owns non-text storage, promotion is still refused.
Validation: python -m pytest tools/test_tubuild.py -q (56 passed), Python compile check, port references 405/405, no new unresolved references, duplicate-source and shadow-TU pre-push gates green.