Skip to content

Scope TU span checks to text sections - #2121

Merged
andrewboudreau merged 1 commit into
mainfrom
tools/tu-span-text-sections-main
Sep 1, 2026
Merged

Scope TU span checks to text sections#2121
andrewboudreau merged 1 commit into
mainfrom
tools/tu-span-text-sections-main

Conversation

@andrewboudreau

Copy link
Copy Markdown
Collaborator

Re-cut of #2109 as requested in review: one commit directly on current main, with no unrelated stack ancestry.

span_entries now selects candidate contributions by .text only, so a neighbouring intact TU with later .data cannot make an adjacent text contribution look straddling. The existing fail-closed rule is retained: if a selected legacy entry itself owns non-text storage, promotion is still refused.

Validation: python -m pytest tools/test_tubuild.py -q (56 passed), Python compile check, port references 405/405, no new unresolved references, duplicate-source and shadow-TU pre-push gates green.

@tangos-validator

tangos-validator Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ PR validation — Passed

noverify: no source/build-data changes in this PR

Each changed src/*.c|*.cpp is compiled and its relocated bytes compared to the binary data on a private build box. Passing requires every changed file to reproduce the ROM byte-for-byte with correct relocation targets — this catches WRONG-DEST relocations and non-reproducing near-misses that ledger-scoped linkcheck skips.

@andrewboudreau andrewboudreau added the attribution-override Maintainer accepts this PR's contributor-credit changes; validation reports them as warnings label Sep 1, 2026
@andrewboudreau
andrewboudreau merged commit 2f62cd8 into main Sep 1, 2026
8 checks passed
@andrewboudreau
andrewboudreau deleted the tools/tu-span-text-sections-main branch September 1, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attribution-override Maintainer accepts this PR's contributor-credit changes; validation reports them as warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant