Skip to content

Spell the TU-promotion metavariable as <Class>, unbreaking main's references gate - #2010

Merged
andrewboudreau merged 1 commit into
mainfrom
fix/dead-ref-placeholder
Aug 30, 2026
Merged

Spell the TU-promotion metavariable as <Class>, unbreaking main's references gate#2010
andrewboudreau merged 1 commit into
mainfrom
fix/dead-ref-placeholder

Conversation

@andrewboudreau

Copy link
Copy Markdown
Collaborator

Main is currently red on dead references at b6da5063f. This fixes it.

What broke

#2007 landed prose in tools/tiers_ratchet.py (3 sites) and notes/converted-tier.md (1 site) that names src/actors/X.cpp as a stand-in for "whichever file the TU promotion absorbed the symbols into".

check_dead_references reads every repo-rooted path appearing in prose as a real reference, so it read the stand-in as a rename that failed to carry into the prose:

FAIL: 2 prose reference(s) name a path that does not exist:
  notes/converted-tier.md
      names `src/actors/X.cpp`, which is not in the tree
  tools/tiers_ratchet.py
      names `src/actors/X.cpp`, which is not in the tree

Every PR cut from main after b6da5063f inherits this red. It is not those PRs' fault and it should not be resolved in those PRs.

The fix, and why not the baseline

Spelled src/actors/<Class>.cpp. GLOBBY in check_dead_references.py:93 already skips any reference containing <>, so the gate stops reading it as a path — and a metavariable is what the sentence meant in the first place.

This is deliberately not check_dead_references.py --update. The escape hatch is for references that are genuinely historical or belong to another repo; this one is neither. It is prose that should be clearer, so it got clearer. Suppressing it would also have left the next reader thinking src/actors/X.cpp was a real file.

The sibling stand-in in the same paragraphs, src/_ZN....cpp, has always been skipped because GLOBBY also matches .... This makes the two consistent — previously one placeholder was invisible to the gate and the other was fatal to it, for no reason a reader could see.

The src/actors/X.cpp literals in tools/test_tiers.py are untouched: they are fixture values in code, not prose, and the gate never read them.

Verification

check_dead_references        no new dead references   (133 unresolved, was 135)
pytest tools/test_tiers.py   29 passed
tiers_ratchet --check        PASS   baseline 2567   current 2567
port_refcheck                405 checked, all resolve
check_src_tu_compiles        88/88

Docs/tooling-prose only. No source file, no delinks entry, no symbol, no byte.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WdCK1xgrJdiJzPCh3bAJfQ

…erences gate

#2007 (b6da506) landed prose in tools/tiers_ratchet.py and
notes/converted-tier.md that names `src/actors/X.cpp` as a stand-in for
"whichever file the promotion absorbed the symbols into".

check_dead_references reads every repo-rooted path in prose as a real
reference, so it read the stand-in as a rename that missed the prose and
turned main red:

    FAIL: 2 prose reference(s) name a path that does not exist
      notes/converted-tier.md      names `src/actors/X.cpp`
      tools/tiers_ratchet.py       names `src/actors/X.cpp`

Spelling it `src/actors/<Class>.cpp` fixes it at the source rather than
suppressing it: GLOBBY already skips any reference containing `<>`, and a
metavariable is what the sentence meant. The sibling stand-in in the same
paragraphs, `src/_ZN....cpp`, has always been skipped for the same reason
(GLOBBY also matches `...`) -- this makes the two consistent.

The `src/actors/X.cpp` literals in tools/test_tiers.py are untouched: they
are fixture values in code, not prose, and the gate never read them.

  check_dead_references  no new dead references (133 unresolved, was 135)
  pytest tools/test_tiers.py   29 passed
  tiers_ratchet --check  PASS  baseline 2567  current 2567

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WdCK1xgrJdiJzPCh3bAJfQ
@tangos-validator

tangos-validator Bot commented Aug 30, 2026

Copy link
Copy Markdown

✅ PR validation — Passed

noverify: no source/build-data changes in this PR

Each changed src/*.c|*.cpp is compiled and its relocated bytes compared to the binary data on a private build box. Passing requires every changed file to reproduce the ROM byte-for-byte with correct relocation targets — this catches WRONG-DEST relocations and non-reproducing near-misses that ledger-scoped linkcheck skips.

@andrewboudreau
andrewboudreau merged commit 2d01d69 into main Aug 30, 2026
6 checks passed
@andrewboudreau
andrewboudreau deleted the fix/dead-ref-placeholder branch August 30, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant