Spell the TU-promotion metavariable as <Class>, unbreaking main's references gate - #2010
Merged
Conversation
…erences gate #2007 (b6da506) landed prose in tools/tiers_ratchet.py and notes/converted-tier.md that names `src/actors/X.cpp` as a stand-in for "whichever file the promotion absorbed the symbols into". check_dead_references reads every repo-rooted path in prose as a real reference, so it read the stand-in as a rename that missed the prose and turned main red: FAIL: 2 prose reference(s) name a path that does not exist notes/converted-tier.md names `src/actors/X.cpp` tools/tiers_ratchet.py names `src/actors/X.cpp` Spelling it `src/actors/<Class>.cpp` fixes it at the source rather than suppressing it: GLOBBY already skips any reference containing `<>`, and a metavariable is what the sentence meant. The sibling stand-in in the same paragraphs, `src/_ZN....cpp`, has always been skipped for the same reason (GLOBBY also matches `...`) -- this makes the two consistent. The `src/actors/X.cpp` literals in tools/test_tiers.py are untouched: they are fixture values in code, not prose, and the gate never read them. check_dead_references no new dead references (133 unresolved, was 135) pytest tools/test_tiers.py 29 passed tiers_ratchet --check PASS baseline 2567 current 2567 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WdCK1xgrJdiJzPCh3bAJfQ
✅ PR validation — Passednoverify: no source/build-data changes in this PR Each changed |
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is currently red on
dead referencesatb6da5063f. This fixes it.What broke
#2007 landed prose in
tools/tiers_ratchet.py(3 sites) andnotes/converted-tier.md(1 site) that namessrc/actors/X.cppas a stand-in for "whichever file the TU promotion absorbed the symbols into".check_dead_referencesreads every repo-rooted path appearing in prose as a real reference, so it read the stand-in as a rename that failed to carry into the prose:Every PR cut from main after
b6da5063finherits this red. It is not those PRs' fault and it should not be resolved in those PRs.The fix, and why not the baseline
Spelled
src/actors/<Class>.cpp.GLOBBYincheck_dead_references.py:93already skips any reference containing<>, so the gate stops reading it as a path — and a metavariable is what the sentence meant in the first place.This is deliberately not
check_dead_references.py --update. The escape hatch is for references that are genuinely historical or belong to another repo; this one is neither. It is prose that should be clearer, so it got clearer. Suppressing it would also have left the next reader thinkingsrc/actors/X.cppwas a real file.The sibling stand-in in the same paragraphs,
src/_ZN....cpp, has always been skipped becauseGLOBBYalso matches.... This makes the two consistent — previously one placeholder was invisible to the gate and the other was fatal to it, for no reason a reader could see.The
src/actors/X.cppliterals intools/test_tiers.pyare untouched: they are fixture values in code, not prose, and the gate never read them.Verification
Docs/tooling-prose only. No source file, no delinks entry, no symbol, no byte.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WdCK1xgrJdiJzPCh3bAJfQ