Read 6.1 alternatives and leave objtool site lists to objtool-report - #46
Merged
Merged
Conversation
tamnd
added
kind/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for
rk sections-diffon 6.1.Linux 6.3 dropped the padding from
struct alt_instr, so an.altinstructionsentry is 12 bytes on 6.1 and 14 from 6.3 on. The entry size is now worked out from the section size and its reloc count (two relocs per entry) rather than assumed to be 14, so 6.1 entries are compared by feature like the newer ones.The site lists objtool writes (
.orc_unwind_ip,.return_sites,.retpoline_sites,.static_call_sites) are no longer counted. Before IBT, as in 6.1 defconfig, objtool runs on every object and writes them into each one. From then on it writes them only intovmlinux.o. Either way they follow from the code objtool reads, andrk objtool-reportis the check for them. Only__mcount_locand__patchable_function_entries, which the compiler writes, are still compared per function. Plan doc 09 says the same.Part of #3.