Record the sanitizer probes as expected and key objtool objects by relative path - #42
Merged
Merged
Conversation
tamnd
added
kind/feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things config-diff and flags-diff reported on the defconfig pair that are not rucc work.
CC_HAS_KASAN_GENERIC,CC_HAS_KASAN_SW_TAGSandHAVE_KCSAN_COMPILERare yes with gcc and no with rucc, andKASANandKCSANonly show up in the gcc .config because of them. rucc has no-fsanitize=kernel-addressor-fsanitize=thread, and section 8.10 of the plan keeps the sanitizers out of the grade, with both off in both builds. They are now in config-divergences.toml with that reason.flags-diff listed all 26 objtool objects as built by one side only. objtool's own makefile names its objects by their full path, so the key had the output directory in it and never matched across builds.
loadnow keys every object relative to the output directory, with a unit test.Part of #3.