Pass the era's assembler version to rucc - #41
Merged
Merged
Conversation
The kernel reads the assembler version from `$(CC) -Wa,--version` in scripts/as-version.sh, so rucc printed its own gas default of 2.46 and CONFIG_AS_VERSION differed from the gcc build. The persona now carries -fgnu-as-version from the era, and the shim drops it before calling the other compiler, the same as -fgnuc-version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel finds the assembler version by running
$(CC) -Wa,--versionin scripts/as-version.sh. rucc answered with its own default of 2.46, so CONFIG_AS_VERSION in the rucc build did not match the gcc 14 build, which uses binutils 2.44. That was one of the unexplained lines inrk config-diff.The persona now passes
-fgnu-as-version=from the era next to-fgnuc-version=. The flags, probes and syntax checks skip it the same way they skip the gcc version, and the bring-up shim does not pass it on to the other compiler.Part of #3.