Skip KUnit tests in the configuration, not on the command line - #65
Merged
Merged
Conversation
This was referenced Oct 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61 skipped the flaky KUnit suites with
kunit.filter=module!=...on the command line. On 7.2.8 that filter panics the kernel before any test runs:attr_string_filtercallsstrcmpon the module name of a test case that has none, so every M14 KUnit boot died and the cells landed at L6. I stopped both queues once the first cells showed it.This moves the skip into the configuration step. The
# gk:kunit-skipline now names Kconfig options. After the fragment is applied, gk turnsKUNIT_ALL_TESTSoff in the resolved.config, which shows the test prompts again with the values it gave them, turns the named options off and runsolddefconfigagain intokunit-skip.log. I tried that by hand on a 7.2.8 cell's config: the only symbols that change are the two tests,KUNIT_ALL_TESTSandDRM_SCHED, which only the scheduler test selects. Every other test stays on. A named option that is still on afterwards shows up infragment_missed.The boot side of #61 is reverted. M14 skips
DRM_SCHED_KUNIT_TESTandRATELIMIT_KUNIT_TEST, and spec 07 explains why the command line filter is not used.Checked on server2: fmt, clippy with
-D warnings, tests and the style script pass.