Skip to content

Skip KUnit tests in the configuration, not on the command line - #65

Merged
tamnd merged 1 commit into
mainfrom
kunit-skip-config
Oct 3, 2026
Merged

tamnd merged 1 commit into
mainfrom
kunit-skip-config

Conversation

@tamnd

@tamnd tamnd commented Oct 3, 2026

Copy link
Copy Markdown
Owner

#61 skipped the flaky KUnit suites with kunit.filter=module!=... on the command line. On 7.2.8 that filter panics the kernel before any test runs: attr_string_filter calls strcmp on the module name of a test case that has none, so every M14 KUnit boot died and the cells landed at L6. I stopped both queues once the first cells showed it.

This moves the skip into the configuration step. The # gk:kunit-skip line now names Kconfig options. After the fragment is applied, gk turns KUNIT_ALL_TESTS off in the resolved .config, which shows the test prompts again with the values it gave them, turns the named options off and runs olddefconfig again into kunit-skip.log. I tried that by hand on a 7.2.8 cell's config: the only symbols that change are the two tests, KUNIT_ALL_TESTS and DRM_SCHED, which only the scheduler test selects. Every other test stays on. A named option that is still on afterwards shows up in fragment_missed.

The boot side of #61 is reverted. M14 skips DRM_SCHED_KUNIT_TEST and RATELIMIT_KUNIT_TEST, and spec 07 explains why the command line filter is not used.

Checked on server2: fmt, clippy with -D warnings, tests and the style script pass.

@tamnd tamnd added this to the G1: the current stripe milestone Oct 3, 2026
@tamnd tamnd added kind/bug Something produces a wrong cell, verdict or report area/boot QEMU rig, gk-init, smoke suites and KUnit labels Oct 3, 2026
@tamnd
tamnd merged commit 7c4b871 into main Oct 3, 2026
@tamnd
tamnd deleted the kunit-skip-config branch October 3, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/boot QEMU rig, gk-init, smoke suites and KUnit kind/bug Something produces a wrong cell, verdict or report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant