Skip to content

Fix invalid escape sequences #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mirochill wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix invalid escape sequences #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bash_kernel/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

$ cat dog.png | display
$ echo "<b>Dog</b>, not a cat." | displayHTML
$ echo "alert('It is known khaleesi\!');" | displayJS
$ echo "alert('It is known khaleesi\\!');" | displayJS

### Updating rich content cells

Expand Down
6 changes: 3 additions & 3 deletions bash_kernel/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@ def _start_bash(self):
# replwrap seeing that as the next prompt, we'll embed the marker characters
# for invisible characters in the prompt; these show up when inspecting the
# environment variable, but not when bash displays the prompt.
ps1 = self.unique_prompt + u'\[\]' + ">"
ps2 = self.unique_prompt + u'\[\]' + "+"
ps1 = self.unique_prompt + u'\\[\\]' + ">"
ps2 = self.unique_prompt + u'\\[\\]' + "+"
prompt_change = u"PS1='{0}' PS2='{1}' PROMPT_COMMAND=''".format(ps1, ps2)
# Using IREPLWrapper to get incremental output
self.bashwrapper = IREPLWrapper(child, u'\$', prompt_change, self.unique_prompt,
self.bashwrapper = IREPLWrapper(child, u'\\$', prompt_change, self.unique_prompt,
extra_init_cmd="export PAGER=cat",
line_output_callback=self.process_output)
finally:
Expand Down