README.md: update required scopes for oauth clients - #182
Conversation
Document the `all:read` and `devices:core` required scopes discussed in tailscale#100 Signed-off-by: Seb Pretzer <24555985+sebpretzer@users.noreply.github.com>
|
Hey @sebpretzer ! Were you seeing errors or failures when using the action without I've put up #183 which added a second OAuth client to our test suite with just the |
|
@mpminardi, you are absolutely correct, only I did not previously test it out, I had taken this comment at face value and tested out the 3 scopes, which obviously worked because I tested a newly scoped client with just |
|
Glad to hear that things are working as expected! And no worries, thank you for opening the PR! Lead to uncovering that we weren't testing the new scopes in CI and to better regression testing coverage as a result 🙂 |
The guidance provided for the proper scopes for oauth clients is incomplete. It only includes the
auth_keysscope, but any oauth client using this github action should also includeall:readanddevices:core. This follows the suggestion provided in #100 (comment).I have attempted to follow the contributing guidelines found in commit-messages.md.
Note: The documentation on tailscale's website will need to be updated as well.