add support for testing peer connectivity - #7
Merged
Merged
Conversation
oxtoacart
force-pushed
the
percy/corp32817
branch
from
September 29, 2025 14:50
5edfc60 to
97dc17c
Compare
oxtoacart
force-pushed
the
percy/corp32817
branch
18 times, most recently
from
September 29, 2025 18:13
b0d03e0 to
b43c5ba
Compare
oxtoacart
commented
Sep 29, 2025
oxtoacart
commented
Sep 29, 2025
mcoulombe
reviewed
Sep 29, 2025
| retry: number; | ||
| useCache: boolean; | ||
| sha256Sum: string; | ||
| ping: string; |
There was a problem hiding this comment.
Can this be declared as an array of strings instead of a string we have to parse during the execution? It'd be good if the interface matches the desired shape of the inputs as much as possible.
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, core.getInput() doesn't support arrays, so the best I can do is move the existing splitting logic to getInputs().
Collaborator
Author
There was a problem hiding this comment.
Okay, I moved the parsing into getInputs().
mcoulombe
reviewed
Sep 29, 2025
jaxxstorm
reviewed
Sep 29, 2025
mcoulombe
reviewed
Sep 29, 2025
oxtoacart
force-pushed
the
percy/corp32817
branch
from
September 29, 2025 19:16
b43c5ba to
d54741d
Compare
The new argument `ping` allows users to specify a comma-seperated list of hosts (IP or hostname) to ping in order to verify connectivity. Ping is considered successful as soon as the peer is reachable either directly or via DERP. Updates tailscale/corp#32817 Signed-off-by: Percy Wegmann <percy@tailscale.com>
oxtoacart
force-pushed
the
percy/corp32817
branch
from
September 29, 2025 19:18
d54741d to
c212a5d
Compare
mcoulombe
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new argument
pingallows users to specify a comma-seperated list of hosts (IP or hostname) to ping in order to verify connectivity. Ping is considered successful as soon as the peer is reachable either directly or via DERP.Updates tailscale/corp#32817