fix(http): wait for session manager readiness before handling requests#315
Open
syf2211 wants to merge 1 commit into
Open
fix(http): wait for session manager readiness before handling requests#315syf2211 wants to merge 1 commit into
syf2211 wants to merge 1 commit into
Conversation
Replace the unreliable asyncio.sleep(0.1) startup delay with an event signaled once StreamableHTTPSessionManager.run() has initialized its task group. This prevents mount_http() requests from hanging when the message router is not ready yet. Fixes tadata-org#259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the unreliable
asyncio.sleep(0.1)startup delay inFastApiHttpSessionManager._ensure_session_manager_started()with anasyncio.Eventthat is signaled onceStreamableHTTPSessionManager.run()has initialized its internal task group.Motivation
Fixes #259. When using
mount_http(), POST requests to/mcpcould hang indefinitely because requests were handled before the StreamableHTTP message router was ready. A fixed 100ms sleep does not guarantee initialization on slower systems or under load.Changes
run()context instead of sleeping_manager_startedonly after readiness is confirmed (also closes a race where concurrent callers could proceed too early)task.result()_task_groupis initialized after startupTests
uv run pytest tests/test_http_transport.py -q --no-cov— PASSuv run pytest tests/test_http_real_transport.py::test_http_initialize_request -q --no-cov— PASSuv run ruff check fastapi_mcp/transport/http.py tests/test_http_transport.py— PASSuv run mypy fastapi_mcp/transport/http.py— PASSNotes
Composer-2.5 review: APPROVE. No blocking issues found.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.