Skip to content

docs(review): Update code review rules#142

Merged
tab merged 2 commits into
masterfrom
fix/claude
Jun 6, 2026
Merged

docs(review): Update code review rules#142
tab merged 2 commits into
masterfrom
fix/claude

Conversation

@tab

@tab tab commented Jun 6, 2026

Copy link
Copy Markdown
Owner
  • Use CLAUDE.md the single source of truth for architecture, code style, logging, concurrency and security
  • Slim .github/CODE_REVIEW.md to review process only: severity, PR hygiene, breaking changes and output format
  • Rewrite .github/CODE_REVIEW_PROMPT.md to use CLAUDE.md
  • Eliminate cross-file duplication so each rule lives in one place

Use CLAUDE.md the single source of truth for architecture, code style, logging, concurrency and security
Slim .github/CODE_REVIEW.md to review process only: severity, PR hygiene, breaking changes and output format
Rewrite .github/CODE_REVIEW_PROMPT.md to use CLAUDE.md
Eliminate cross-file duplication so each rule lives in one place
@tab tab requested a review from Copilot June 6, 2026 10:10
@tab tab self-assigned this Jun 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the repository’s documentation for AI-assisted development and code review by making CLAUDE.md (+ .claude/skills/*) the canonical source for code rules and reducing .github/CODE_REVIEW.md to the review process and output format.

Changes:

  • Slims .github/CODE_REVIEW.md to severity, PR hygiene, breaking changes, and review output format.
  • Rewrites .github/CODE_REVIEW_PROMPT.md and .github/copilot-instructions.md to reference CLAUDE.md/skills as authoritative for code rules.
  • Adds procedure “skills” docs for verify, test-writing, mock generation, and config reference.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CLAUDE.md Refocuses as the canonical code-rules document; trims architectural narrative and centralizes guidelines + workflows.
.github/copilot-instructions.md Updates Copilot authority chain to prefer CLAUDE.md + skills for code rules and .github/* for review process.
.github/CODE_REVIEW.md Rewritten to cover only PR review process (severity/hygiene/breaking/output format) and defer code rules to CLAUDE.md/skills.
.github/CODE_REVIEW_PROMPT.md Updates the multi-pass checklist to cite CLAUDE.md sections and skills for code-rule checks.
.claude/skills/fuku-verify/SKILL.md Documents the standard verification loop commands (fmt/lint/vet/test/race/e2e).
.claude/skills/fuku-generate-mock/SKILL.md Documents mockgen conventions (paths, placement, no //go:generate).
.claude/skills/fuku-config/SKILL.md Adds a fuku.yaml schema reference and semantics notes.
.claude/skills/fuku-add-test/SKILL.md Documents the table-driven test pattern and related test conventions.

Comment thread CLAUDE.md Outdated
Comment thread .github/CODE_REVIEW_PROMPT.md
@sentry

sentry Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (a63b869) to head (1e6dbdf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          66       66           
  Lines        6658     6658           
=======================================
  Hits         5962     5962           
- Misses        537      538    +1     
+ Partials      159      158    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

We traps SIGINT and SIGTERM and escalates to SIGKILL only when child processes don't exit

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Comment thread CLAUDE.md
Comment thread CLAUDE.md
@tab tab merged commit 08064d6 into master Jun 6, 2026
18 of 19 checks passed
@tab tab deleted the fix/claude branch June 6, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants