docs(review): Update code review rules#142
Merged
Merged
Conversation
tab
commented
Jun 6, 2026
Owner
- Use CLAUDE.md the single source of truth for architecture, code style, logging, concurrency and security
- Slim .github/CODE_REVIEW.md to review process only: severity, PR hygiene, breaking changes and output format
- Rewrite .github/CODE_REVIEW_PROMPT.md to use CLAUDE.md
- Eliminate cross-file duplication so each rule lives in one place
Use CLAUDE.md the single source of truth for architecture, code style, logging, concurrency and security Slim .github/CODE_REVIEW.md to review process only: severity, PR hygiene, breaking changes and output format Rewrite .github/CODE_REVIEW_PROMPT.md to use CLAUDE.md Eliminate cross-file duplication so each rule lives in one place
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the repository’s documentation for AI-assisted development and code review by making CLAUDE.md (+ .claude/skills/*) the canonical source for code rules and reducing .github/CODE_REVIEW.md to the review process and output format.
Changes:
- Slims
.github/CODE_REVIEW.mdto severity, PR hygiene, breaking changes, and review output format. - Rewrites
.github/CODE_REVIEW_PROMPT.mdand.github/copilot-instructions.mdto referenceCLAUDE.md/skills as authoritative for code rules. - Adds procedure “skills” docs for verify, test-writing, mock generation, and config reference.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
CLAUDE.md |
Refocuses as the canonical code-rules document; trims architectural narrative and centralizes guidelines + workflows. |
.github/copilot-instructions.md |
Updates Copilot authority chain to prefer CLAUDE.md + skills for code rules and .github/* for review process. |
.github/CODE_REVIEW.md |
Rewritten to cover only PR review process (severity/hygiene/breaking/output format) and defer code rules to CLAUDE.md/skills. |
.github/CODE_REVIEW_PROMPT.md |
Updates the multi-pass checklist to cite CLAUDE.md sections and skills for code-rule checks. |
.claude/skills/fuku-verify/SKILL.md |
Documents the standard verification loop commands (fmt/lint/vet/test/race/e2e). |
.claude/skills/fuku-generate-mock/SKILL.md |
Documents mockgen conventions (paths, placement, no //go:generate). |
.claude/skills/fuku-config/SKILL.md |
Adds a fuku.yaml schema reference and semantics notes. |
.claude/skills/fuku-add-test/SKILL.md |
Documents the table-driven test pattern and related test conventions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 66 66
Lines 6658 6658
=======================================
Hits 5962 5962
- Misses 537 538 +1
+ Partials 159 158 -1 🚀 New features to boost your workflow:
|
We traps SIGINT and SIGTERM and escalates to SIGKILL only when child processes don't exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.