Keep-alive connection handling, refactor state machine parser#10
Merged
Conversation
- handle keep-alive headers according to HTTP/1.1 and HTTP/1.0, persist connections if the protocol framing is valid - wrap state machine transitions with a common public method (http.run()), catching exceptions and terminating the state machine uniformly - introduce abort() method for irregular parser termination where the correctness of protocol framing cannot be ensured for subsequent requests; use abort() to prevent the connection to be reused regardless of keep-alive settings - remove public methods specific to HTTP response codes, use http.terminate() and http.abort() methods instead (expecting a status code argument directly); terminate() and abort() are now usable by application code to set status codes - do not require response buffer argument for state machine transitions; response buffers are written only through http.write_response_head() and http.set_response_body() after the state machine has terminated - raise runtime error when an invalid response handler is set instead of terminating the state machine; this avoids terminating the state machine multiple times leading to invalid/ambiguous response framing - shorten/clarify the names of parser exceptions - update content-length validation to allow more data to be present in the request buffer compared to the indicated content-length; consider excess data as subsequent request if keep-alive is enabled and HTTP framing is valid - add missing close() for byte streams (FileIO, BytesIO)
Each test uses a new socket connection, disable persistent connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.