Skip to content

chore: remove .vscode directory - #418

Merged
agicy merged 1 commit into
syswonder:devfrom
agicy:chore/remove-vscode
Nov 8, 2026
Merged

agicy merged 1 commit into
syswonder:devfrom
agicy:chore/remove-vscode

Conversation

@agicy

@agicy agicy commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove the tracked .vscode/ directory and its three files:

  • .vscode/c_cpp_properties.old.json
  • .vscode/launch.json
  • .vscode/settings-example.json

This is a repository-cleanup change only; it does not touch build logic, runtime code, or target configuration.

Motivation

The tracked VS Code files are editor-specific and have become stale:

  • launch.json points at target/aarch64/debug/hvisor, which no longer matches the current build layout.
  • c_cpp_properties.old.json hardcodes an old cross-GCC path and is explicitly marked as an old configuration.
  • settings-example.json hardcodes a target triple and has to be updated every time the target changes (for example, the AArch64 softfloat migration).

VS Code settings are also personal/environment-specific. The generated .vscode/settings.json is already ignored by Git and is recreated by make vscode/host_config.sh, so keeping an example file in the repository only adds maintenance cost.

Verification

  • git ls-files .vscode returns no tracked files.
  • make ARCH=aarch64 BOARD=qemu-gicv3 defconfig succeeds.
  • git status --short is clean after the change.

No runtime or QEMU test is needed for an editor-configuration-only removal.

Risks and Limitations

  • Contributors who relied on the example Rust Analyzer target configuration will need to configure rust-analyzer.cargo.target locally.
  • make vscode / tools/kconfig/host_config.sh vscode can still create an ignored local .vscode/settings.json; this PR removes tracked files only, not the local-generation behavior.
  • No CI, build, or hypervisor behavior is affected.

@agicy
agicy requested a review from li041 November 8, 2026 14:28

@li041 li041 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agicy
agicy merged commit e308458 into syswonder:dev Nov 8, 2026
25 of 30 checks passed
@agicy
agicy deleted the chore/remove-vscode branch November 8, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants