Repository navigation
fix(x86_64): model virtual IOAPIC interrupt lines - #410
Merged
Merged
Conversation
Solicey
marked this pull request as ready for review
October 28, 2026 02:39
Solicey
marked this pull request as draft
November 1, 2026 02:58
Solicey
force-pushed
the
fix_x86_ioapic
branch
2 times, most recently
from
November 1, 2026 03:57
3bd36f7 to
9a1a0d7
Compare
Solicey
force-pushed
the
fix_x86_ioapic
branch
from
November 1, 2026 04:04
9a1a0d7 to
9284f67
Compare
Collaborator
|
This PR seems to break riscv64. In src/hypercall/mod.rs, the old not(target_arch = "loongarch64") also covered riscv64, but it’s now aarch64 / any(aarch64, loongarch64). As a result, riscv64 fails to build. Even after fixing the build, hv_virtio_inject_irq never advances res_agent and loops forever without injecting any IRQ, and hv_zone_shutdown no longer takes the VIRTIO_IRQS lock or clears the zone’s irq_list. |
peikachu
reviewed
Nov 1, 2026
agicy
reviewed
Nov 2, 2026
Solicey
force-pushed
the
fix_x86_ioapic
branch
from
November 3, 2026 14:16
9284f67 to
d8718bd
Compare
Solicey
marked this pull request as ready for review
November 8, 2026 13:14
peikachu
reviewed
Nov 9, 2026
Solicey
force-pushed
the
fix_x86_ioapic
branch
from
November 9, 2026 14:16
d8718bd to
d769574
Compare
peikachu
reviewed
Nov 9, 2026
Solicey
force-pushed
the
fix_x86_ioapic
branch
from
November 9, 2026 16:16
d769574 to
0939c4b
Compare
Solicey
force-pushed
the
fix_x86_ioapic
branch
from
November 10, 2026 14:29
0939c4b to
994d697
Compare
peikachu
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Linux briefly changes a level-triggered IOAPIC redirection table entry (RTE) to masked + edge while handling EOI. If a virtio completion arrived during that window, hvisor dropped it according to the temporary RTE value, even though the device's interrupt line remained asserted. Zone1 could then hang waiting for I/O, as reported in #409.
Changes