feat: use binary COPY for Postgres insert#34
Open
lewiszlw wants to merge 1 commit into
Open
Conversation
Replace the text-based INSERT SQL approach with Postgres binary COPY protocol via BinaryCopyInWriter. This improves performance and correctness for complex data types. Key changes: - Rewrite insert() to use COPY ... FROM STDIN BINARY - Add PgValue enum implementing ToSql for all supported types - Add custom write_numeric_to_sql for NUMERIC binary encoding - Fix JSONB binary format (version prefix byte) - Fix interval binary encoding byte order - Add format_decimal_i128/i256 helpers for correct Decimal conversion All 19 postgres integration tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the text-based INSERT SQL approach with Postgres binary COPY protocol via BinaryCopyInWriter. This improves performance and correctness for complex data types.
Key Changes