Fix Build Issues#886
Open
Symmetricity wants to merge 3 commits into
Open
Conversation
The Boost 1.89 build fix removed output_object.h's geom.h include to keep Boost.Geometry out of this header, but the OutputObject constructor still used the uint alias that geom.h defines for MSVC. Use unsigned int for the minzoom constructor parameter instead, matching the existing minZoom bitfield type and avoiding the non-standard alias.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is AI generated.
Summary
This restores the ability to build from source across multiple operating systems by resolving several outstanding issues.
uintbuild failure inOutputObjectboost_systemin the Makefile when the library exists, but omit it when Boost no longer ships itBoost::throw_exceptionfrom CMake when that imported target is available<cstdint>fromhelpers.h, which directly uses fixed-width integer typesFixes #880.
Fixes #882.
Background
Recent builds fail:
include/output_object.hbecauseuintis no longer available after the Boost 1.89 compatibility changeslibboost_systemThis follows the Boost 1.89+ compatibility work in #871 and the Boost.System removal reports in #862 and #880.
Testing
cmake -S . -B build-ci-fix -DCMAKE_BUILD_TYPE=RelWithDebInfocmake --build build-ci-fix --target tilemaker -j2make -j4make testcmake -DTILEMAKER_BUILD_STATIC=ON -DVCPKG_TARGET_TRIPLET=x64-windows-static-md -DCMAKE_TOOLCHAIN_FILE=C:\vcpkg\scripts\buildsystems\vcpkg.cmake ..cmake --build . --config RelWithDebInfo