Repository navigation
Conversation
A patch that renames a note's H1 or front-matter title leaves the listed title as it was, since HackMD never renames a note for a body edit. Pull and push already report that mismatch as title_drift; a patch edit on hackmd_update_note did not, so the caller had to notice it alone. A patch now reports it the way push does. The body before the patch stands in for the last-synced one: drift is reported only when that body's title matched the listing, so a heading kept apart from the title on purpose stays silent, as does a first H1 added to a body that had none. It is judged against the title the read-back returns, so a rename made while the patch was in flight is not reported. A patch that changes nothing writes nothing and reports no drift.
Older course pages link notes as https://hackmd.io/s/<shortId>, a share link HackMD redirects to the note's published address, and the tools refused it. Such a link names no workspace, so the note is found by its shortId: with team_path only that team is listed, and without one the personal notes and then every team. A shortId found more than once comes back as candidates, never a guess. A team whose list fails fails the search, since the note may be there, and the error says that team_path narrows it while keeping the kind of the error it wraps. Push cross-checks its note_ref the same way, across every workspace, so a short link naming another workspace's note is a tracking mismatch rather than a not-found. Restore refuses a short link like an @owner/slug URL, since trashed notes are never listed. A trailing /download, the address that checks a published copy, is dropped from a complete reference, so a slug that is itself download still names its note. The host of a scheme-less hackmd.io reference is matched case-insensitively, as the URL parser already did with a scheme; the path stays case-sensitive.
Tool inputs read team_path as a Workspace, which defaults to the
personal one, so "no team_path given" and "the personal workspace"
were the same value. Each caller that needed the difference guessed at
it: a short link searched every workspace when it saw Personal, push
swapped Personal for the tracked note's workspace unless the reference
was a URL, and the tracked list treated Personal as "every workspace".
A guard missing from one of those lists is how push came to search
only the tracked team for a short link.
The inputs that take a team_path now hold Option<Workspace>, and
resolve_note_ref decides once what None means: personal for a bare ID,
every workspace for a short link, the URL's own for @owner/slug. Push
passes the tracked workspace as the home of a bare ID through
resolve_note_ref_from rather than rewriting team_path. The guards are
gone.
On the wire nothing changes for an omitted team_path, a null one
(which MCP clients send for an unset field), or a team path, and the
schema is the same nullable string. Only the older tagged form can say
{"kind": "personal"} explicitly, and it now means personal alone: a
short link searches personal notes only, the tracked list keeps
personal records only, push refuses it for a team-tracked note, and an
@owner/slug URL owned by someone else is refused as a mismatch.
The previous commit let the older tagged {"kind": "personal"} object
mean the personal workspace alone. Clients built against that older
schema send it as their default on every call, so they would have lost
team URLs, sync checks, pushes of team-tracked files and the full
tracked list. A team_path input now goes through models::given, which
reads null, omission and the tagged personal object alike as none
given, so only a team is ever Some. The refusal of an explicit
personal workspace beside another owner's URL could no longer happen
and is gone.
Short-link resolution now shares the slug path's candidate building
and its found, not found or ambiguous decision instead of copying
them. A patch edit keeps only the title of its read-back rather than
a second copy of the body while it judges drift.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The team_path docs said to omit it for personal notes, which does not hold for an s/<shortId> link: omitted, it searches the personal notes and then every team. The note_ref docs now also say a trailing /download is ignored, and the update tool says a patch reports title_drift only when the listed title matched the body's title before the patch. A test now reads ListNotesInput with no team_path, a null one, and the older tagged personal object, and checks that history accepts each rather than refusing it as a team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older course pages link notes as
https://hackmd.io/s/<shortId>, which the tools refused. A short link names no workspace, so it is now found by its shortId: withteam_pathonly that team is searched, without one the personal notes and then every team, and a shortId found more than once comes back as candidates rather than a guess. A trailing/download(the published-copy address) is accepted too. Patch edits onhackmd_update_notenow reporttitle_driftthe way pull and push do, since renaming a note's H1 by patch never renames the note.Supporting that meant telling an omitted
team_pathfrom the personal workspace: tool inputs now holdOption<Workspace>, andresolve_note_refdecides once what "none given" means for each kind of reference, which removes the guards that had let push search only the tracked team for a short link. On the wire nothing changes:null, an omitted field and the older tagged{"kind": "personal"}default all still mean "none given", and theteam_pathschema is the same nullable string.Verified with
make check(407 unit tests plus the integration targets) andcargo clippy --all-targets --all-features -- -D warnings, both clean. Reviewed by Codex, Agy and Claude across two rounds plus/code-reviewand/simplify. Live suites were not run. Left out: running team listings concurrently (risks 429 bursts on accounts in many teams) andtitle_driftfor whole-bodycontentreplacements.Summary by cubic
Accepts legacy
https://hackmd.io/s/<shortId>share links as note references in every tool and reportstitle_drifton patch edits inhackmd_update_note, which previously kept that rename mismatch silent.Legacy share links
team_pathonly that team is searched; without one, personal notes and then every team are searched, using the existing 60-second caches.shortIdfound in more than one workspace returns candidates, never a guess, and a team whose list fails fails the search with an error suggestingteam_path./downloadis ignored, and push cross-checks a short link across all workspaces so a link naming another workspace's note is a tracking mismatch.Option<Workspace>so an omittedteam_pathdiffers from the personal workspace;resolve_note_refdecides once what "none given" means for each reference kind. On the wire nothing changes:null, omission, and the older tagged{"kind": "personal"}still mean none given.Patch title drift
title:or a leading H1 reports the implied title astitle_drift, judged against the read-back's title like push does.Written for commit 7792289. Summary will update on new commits.